Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyQt4 installation check fails as pyqtconfig is no longer built by default #3021

Closed
davidia opened this issue Apr 29, 2014 · 4 comments · Fixed by #3022
Closed

PyQt4 installation check fails as pyqtconfig is no longer built by default #3021

davidia opened this issue Apr 29, 2014 · 4 comments · Fixed by #3022
Milestone

Comments

@davidia
Copy link

davidia commented Apr 29, 2014

From http://pyqt.sourceforge.net/Docs/PyQt4/build_system.html :
"SIP v5 will not provide an equivalent of the pyqtconfig module"

setupext.py:

def check_requirements(self):
    try:
        from PyQt4 import pyqtconfig
    except ImportError:
        raise CheckFailed("PyQt4 not found")

This check failed for me after installing latest PyQt4

@tacaswell tacaswell added this to the v1.4.0 milestone Apr 29, 2014
@tacaswell
Copy link
Member

Any suggestions on what we should use as a test import instead? I assume that pyqtconfig was picked because it is fast to import (maybe?).

@mdboom
Copy link
Member

mdboom commented Apr 29, 2014

It was chosen because it contains the version info that we want to display. As long as we can get that information in some other way (maintaining backward compatibility for older version of PyQt), we should be fine.

@davidia
Copy link
Author

davidia commented Apr 29, 2014

How do you go about testing backward compatibility?

@jenshnielsen
Copy link
Member

Are you actually testing from a development branch of SIP. The issue does not exist with for me with pyqt build against the latest version of sip 4.15.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants