New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
symlog-scale: Remove asssert linscale >= 1. #3053
Conversation
There is a known intermittent failure on travis on 3.2 for font priority. |
@mdboom Can you take a look at this? My only worry is that there was a good reason for |
@Tillsten Could you please add a CHANGELOG entry? |
I can't see why the assert was needed and it does excatly what i would expect from it.
done, failure due to unrelated font issues. |
If @mdboom doesen't have time, can we merge it anyways? I see no broken behavior |
@tacaswell, This looked reasonable, so I did the manual changelog merge and pushed. It looks like I should have done it all in one merge operation instead of 2; I haven't done this for a while. |
Thanks! |
I can't see why the assert was needed and it does excatly what i would expect from it.