Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements in finance.py #3094

Closed
3 tasks
montefra opened this issue May 30, 2014 · 2 comments
Closed
3 tasks

Various improvements in finance.py #3094

montefra opened this issue May 30, 2014 · 2 comments

Comments

@montefra
Copy link
Contributor

While working on #3060, I've added a private function to check the input of some other functions.

I suggest:

  • Improve (some) docstring: e.g. in some function there is information about the input structure in the code comments and this should be moved into the docstring
  • Avoid using buildin for variable names
  • Improve loops: e.g. avoid use zip(xrange(len(a)), a, ...) when zip(itertools.count(), a, ...) or enumerate(a) would suffice
@tacaswell
Copy link
Member

The current plan is to deprecate the finance module in 1.4.

@montefra
Copy link
Contributor Author

thanks for the info. Then we can close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants