Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC : added note about maintain ref to widgets #3132

Merged
merged 2 commits into from Jun 10, 2014

Conversation

tacaswell
Copy link
Member

Added note to widget doc-strings that the user must maintain a reference
to the widgets to keep them responsive (if they get gc'd the call backs
go away).

Some random conversion to numpyboc

Closes #3105

Added note to widget doc-strings that the user must maintain a reference
to the widgets to keep them responsive (if they get gc'd the call backs
go away).

Some random conversion to numpyboc

Closes matplotlib#3105
"""Widget that is connected to a single
:class:`~matplotlib.axes.Axes`.

To guarantee that the widgets stay responsive maintain a reference
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comma:

widgets stay responsive, maintain a reference ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe turn the whole sentence into:

To guarantee that a widget remains responsive and not garbage-collected, a reference to the object should be maintained by the user.

 - corrected docstring in Slider.__init__
 - feedback on previous commit
pelson added a commit that referenced this pull request Jun 10, 2014
DOC : added note about maintain ref to widgets
@pelson pelson merged commit 4c6b2cc into matplotlib:master Jun 10, 2014
@tacaswell tacaswell deleted the widget_doc branch June 10, 2014 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sliders unresponsive when created inside a function
4 participants