Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3dquiver rebranch #3149

Merged
merged 12 commits into from Jun 27, 2014
Merged

3dquiver rebranch #3149

merged 12 commits into from Jun 27, 2014

Conversation

WeatherGod
Copy link
Member

Replaces #2961

@pelson
Copy link
Member

pelson commented Jun 26, 2014

👍 Thanks for finishing it off @WeatherGod. I'll merge this happily once travis gets back to us.

@tacaswell tacaswell added this to the v1.4.0 milestone Jun 27, 2014
tacaswell added a commit that referenced this pull request Jun 27, 2014
@tacaswell tacaswell merged commit cec78a7 into matplotlib:master Jun 27, 2014
The team members are: Ryan Steve D'Souza, Victor B, xbtsw, Yang Wang, David,
Caradec Bisesar and Vlad Vassilovski.

.. plot:: mpl_examples/quiver3d_demo.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should have the mplot3d subfolder in the path.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

On Fri, Jun 27, 2014 at 2:35 PM, Thomas Kluyver notifications@github.com
wrote:

In doc/users/whats_new.rst:

@@ -224,6 +224,16 @@ to ensure that the calculated theta value was between the range of 0 and 2 * pi
since the problem was that the value can become negative after applying the
direction and rotation to the theta calculation.

+Simple quiver plot for mplot3d toolkit
+``````````````````````````````````````
+A team of students in an Engineering Large Software Systems course, taught
+by Prof. Anya Tafliovich at the University of Toronto, implemented a simple
+version of a quiver plot in 3D space for the mplot3d toolkit as one of their
+term project. This feature is documented in :func:~mpl_toolkits.mplot3d.Axes3D.quiver.
+The team members are: Ryan Steve D'Souza, Victor B, xbtsw, Yang Wang, David,
+Caradec Bisesar and Vlad Vassilovski.
+
+.. plot:: mpl_examples/quiver3d_demo.py

I think this should have the mplot3d subfolder in the path.


Reply to this email directly or view it on GitHub
https://github.com/matplotlib/matplotlib/pull/3149/files#r14307934.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, where did the fix go? I can't see a commit or a PR for it.

I've also recorded the problem this causes as issue #3161.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I missed that this PR was merged already. I had just simply updated my branch. I'll fix that.

@takluyver takluyver mentioned this pull request Jun 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants