Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG : patch from mikofski to fix webagg example #3205

Closed
wants to merge 1 commit into from
Closed

BUG : patch from mikofski to fix webagg example #3205

wants to merge 1 commit into from

Conversation

tacaswell
Copy link
Member

Closes #3204

@tacaswell tacaswell added this to the v1.4.0 milestone Jul 10, 2014
@mikofski
Copy link

See comments to #3204, also, sorry 2nd diff not needed for main repo. Also fix for FigureCanvasWebAgg methods from super class that are called as class methods could be elsewhere, I chose least intrusive path

This was referenced Jul 10, 2014
Closed
Closed
@mikofski
Copy link

I was wrong, this change has already been made in master, backend_bases.FigureCanvasBase.get_supported_filetypes_grouped() and backend_bases.FigureCanvasBase.get_default_filetype() have already been changed to class methods.

@tacaswell tacaswell closed this Jul 10, 2014
@tacaswell tacaswell deleted the webagg_fix branch July 10, 2014 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

embedded_webagg.py example needs patches
3 participants
@tacaswell @mikofski @QuLogic