Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-closing in PolyCollection #3239

Merged
merged 2 commits into from Jul 12, 2014

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Jul 12, 2014

As reported by @WeatherGod, the auto-closing code in PolyCollection always closes back to (0, 0) rather than the original point. Big problem. I guess most of our polys were origined at (0, 0) which is why we never noticed this.

tacaswell added a commit that referenced this pull request Jul 12, 2014
Fix auto-closing in PolyCollection
@tacaswell tacaswell merged commit abdd1cc into matplotlib:master Jul 12, 2014
@image_comparison(baseline_images=['polycollection_close'],
extensions=['png'], remove_text=True)
def test_polycollection_close():
from mpl_toolkits.mplot3d import Axes3D
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that this isn't part of the mpl3d test, rather than the collection tests...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it should be part of the mplot3d tests because mplot3d is optional.

On Sat, Jul 12, 2014 at 5:45 PM, Phil Elson notifications@github.com
wrote:

In lib/matplotlib/tests/test_collections.py:

@@ -475,6 +475,44 @@ def test_EllipseCollection():
ax.autoscale_view()

+@image_comparison(baseline_images=['polycollection_close'],

  •              extensions=['png'], remove_text=True)
    
    +def test_polycollection_close():
  • from mpl_toolkits.mplot3d import Axes3D

I'm surprised that this isn't part of the mpl3d test, rather than the
collection tests...


Reply to this email directly or view it on GitHub
https://github.com/matplotlib/matplotlib/pull/3239/files#r14855507.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump. Did this ever get done?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants