Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animation.convert_path setting to matplotlibrc.template #3251

Merged
merged 1 commit into from Jul 15, 2014
Merged

Add animation.convert_path setting to matplotlibrc.template #3251

merged 1 commit into from Jul 15, 2014

Conversation

cgohlke
Copy link
Contributor

@cgohlke cgohlke commented Jul 14, 2014

Added a note that on Windows the full path to ImageMagicks convert.exe needs to be specified since convert.exe is also the name of a Windows system tool.
See http://matplotlib.1069221.n5.nabble.com/Couldn-t-save-animation-as-gif-td42260.html

@WeatherGod
Copy link
Member

can we have a better name than "convert_path"? At first, I thought it had
something to do with converting Path objects. How about "convert_filepath"?

On Sun, Jul 13, 2014 at 10:06 PM, cgohlke notifications@github.com wrote:

Added a note that on Windows the full path to ImageMagicks convert.exe
needs to be specified since convert.exe is also the name of a Windows
system tool.
See

http://matplotlib.1069221.n5.nabble.com/Couldn-t-save-animation-as-gif-td42260.html

You can merge this Pull Request by running

git pull https://github.com/cgohlke/matplotlib patch-3

Or view, comment on, or merge it at:

#3251
Commit Summary

  • Add animation.convert_path setting to matplotlibrc.template

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#3251.

@mdboom
Copy link
Member

mdboom commented Jul 14, 2014

Or "imagemagick_convert_executable"? (Verbose, but quite clear, I think).

@mdboom
Copy link
Member

mdboom commented Jul 14, 2014

Actually, I see this rcparam isn't new, it just wasn't part of the rctemplate, so changing the name is probably trickier than all that. Let's just leave it as-is for now, and consider deprecating/renaming later.

@mdboom mdboom added this to the v1.4.0 milestone Jul 14, 2014
@dopplershift
Copy link
Contributor

Good catch on the convert.exe problem--I'm not a windows guy, so I completely missed this. In fact, I think it solves a problem for someone I was helping at SciPy.

Looks good to me.

dopplershift added a commit that referenced this pull request Jul 15, 2014
Add animation.convert_path setting to matplotlibrc.template (Thanks to @cgohlke).
@dopplershift dopplershift merged commit bbbc72c into matplotlib:v1.4.x Jul 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants