Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT : better error handling on determining gs version #3277

Merged
merged 1 commit into from Jul 24, 2014

Conversation

tacaswell
Copy link
Member

If we fail to parse the version string return (0, 0) to let
the code for dealing with out-of-date versions of gs handle
the case of not installed.

Partially addreses #3259

@tacaswell tacaswell added this to the v1.4.0 milestone Jul 18, 2014
@jenshnielsen
Copy link
Member

Note as I pointed out in #3259 this should probably be unified with the code in checkdep_ghostscript in the long term i.e. after 1.4

@tacaswell
Copy link
Member Author

I agree this is not ideal, but it is fast to implement and I don't think will break anything else.

@jenshnielsen
Copy link
Member

Agreed, This probably should be cleaned up post 1.4, Same goes for dvipng_hack_alpha in texmanager.py

@WeatherGod
Copy link
Member

heh, seems like the travis failure is unrelated (a slowdown verification in drawing invisible lines failed in py3.3)

@WeatherGod
Copy link
Member

@tacaswell , this PR needs a rebase

@matthew-brett
Copy link
Contributor

Will this avoid the test error of #3259?

The reason I ask is because it would be good to clear the test errors in the automated OSX install tests: https://travis-ci.org/matplotlib/mpl_mac_testing - that would make it easier to keep track of OSX problems in the future.

If we fail to parse the version string return (0, 0) to let
the code for dealing with out-of-date versions of gs handle
the case of not installed.
@tacaswell
Copy link
Member Author

@WeatherGod rebased

@matthew-brett Yes, that is the purpose of this, if it works is a different question.

@tacaswell
Copy link
Member Author

@jenshnielsen Can you make sure I didn't muddle up the process communication?

@jenshnielsen
Copy link
Member

I looks good to me. This happens on the output of the popen communication. There is some scope for some code simplification later on post 1.4.x but not now.

WeatherGod added a commit that referenced this pull request Jul 24, 2014
MNT : better error handling on determining gs version
@WeatherGod WeatherGod merged commit 5680965 into matplotlib:v1.4.x Jul 24, 2014
@tacaswell tacaswell deleted the gs_check branch July 24, 2014 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants