New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy FontProperty objects when creating titles (fix #3327) #3328
Conversation
Could you add a test based on your test code in #3327 ? |
Here it is. I created a new test file, I'm not sure if I shouldn't have put it in test_axes.py (or even somewhere else). |
Looks great. I would probably put it in test_text |
Well, I can do that if you want, but it's really an issue in |
One of the core developers should probably decide on that @tacaswell @mdboom what do you say? |
I am a little bit hesitant about this fix (at least, I wonder if it is as On Wed, Jul 30, 2014 at 11:33 AM, Jens H Nielsen notifications@github.com
|
I'm not too familiar with rcParam context managers but right now (unpatched) when calling |
Only concern is that updating the axes property manager resulting in the title updating could be seen as a feature, not a bug. This should probably get an entry in I would lean toward putting it in We probably only need the png version of this test and can you modify the test to include the right title too? When you change the tests please squash the commits so that we don't end up with multiple versions of these images in the repo. |
I'm sorry, I didn't get that: how would you update the axes property manager to update the title? |
By exactly the same mechanism that cause the bug, the properties are consulted at draw time |
Closed as this is taken care of in #3335 . |
Fix for #3327.