New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test marker styles #3384
Test marker styles #3384
Conversation
This should address issue #2970 |
Thanks! My only comment is it might be worth using a larger marker size so the image comparison has an easier time catching small changes is the markers. |
Makes sense. I'll increase the size |
Actually, what might be even better is to make them progressively larger. On Tue, Aug 19, 2014 at 11:11 AM, Cimarron notifications@github.com wrote:
|
Ok, made them progressively larger |
👍 |
@cimarronm can you rebase this into one commit? As is is now the history will contain the old version of the test image which will grow the repo size more than needed. Otherwise this looks good and ready to merge. |
This should probably also be back-ported to 1.4.x, but it is not critical. |
0e3d40d
to
45cfb2d
Compare
@jenshnielsen Squashed the commits with the two images to only one so the repo size doesn't grow too much |
Added tests for all the various marker styles