Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better check for required dependency libpng #3477

Merged
merged 1 commit into from Sep 8, 2014

Conversation

cimarronm
Copy link
Contributor

This fixes a bug where the setup incorrectly may state that libpng is present and continue building which will eventually error out.

Current behavior

No libpng installed at all

REQUIRED DEPENDENCIES AND EXTENSIONS
...
...
                   png: yes [pkg-config information for 'libpng' could not
                        be found. Using unknown version.]
...
...
<builds until it eventually errors out>

Updated behavior

libpng pkgconfig exists

REQUIRED DEPENDENCIES AND EXTENSIONS
...
...
                   png: yes [version x.y.z]
...
...
<builds>

no libpng pkgconfig bug png.h include exists

REQUIRED DEPENDENCIES AND EXTENSIONS
...
...
                   png: yes [pkg-config information for 'libpng' could not
                        be found. Using unknown version found on system.]
...
...
<builds>

no png.h include at all

REQUIRED DEPENDENCIES AND EXTENSIONS
...
...
                   png: no  [pkg-config information for 'libpng' could not
                        be found.]
...
...
============================================================================
                        * The following required packages can not be built:
                        * png
<does not build>

@cimarronm cimarronm changed the title BUG: If pkgconfig returns nothing for libpng at least check for header f... Better check required dependency libpng Sep 6, 2014
@cimarronm cimarronm changed the title Better check required dependency libpng Better check for required dependency libpng Sep 6, 2014
@tacaswell tacaswell added this to the v1.4.x milestone Sep 6, 2014
@tacaswell tacaswell modified the milestones: v1.4.1, v1.4.x Sep 8, 2014
tacaswell added a commit that referenced this pull request Sep 8, 2014
BLD : Better check for required dependency libpng
@tacaswell tacaswell merged commit a44673b into matplotlib:master Sep 8, 2014
tacaswell added a commit that referenced this pull request Sep 12, 2014
BLD : Better check for required dependency libpng
@tacaswell
Copy link
Member

cherry-picked as ef2ea6a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants