general pep8 fixes #3507
general pep8 fixes #3507
Conversation
…s to reflect the fixes
cimarronm
force-pushed
the
pep8_fixes
branch
from
f540db6
to
b2408c3
Compare
|
Did you do this by hand or with an auto-pep8 tool? (If it is an automatic tool I want at least one more person to read over this and if my hand I am happy to merge this now). |
|
This is by painstaking hand ;) I wouldn't trust a tool to be smart enough to do the right thing in every situation (of course, that doesn't mean I wouldn't make some stupid mistake as well). I'm going to keep going through the code and try to clean things up for pep8 and get test_coding_standards to where it is checking everything. |
|
Great! Do you want to keep accumulating changes here or merge this and do the next batch as a new PR? I would suggest the second as it reduces the chances of picking up merge conflicts. |
|
That makes sense. Go ahead and merge and I'll do the next bath as a new PR. Thanks |
|
|
||
| - *dayfirst*: default is False so that MM-DD-YY has precedence over | ||
| DD-MM-YY. See http://labix.org/python-dateutil#head-b95ce2094d189a89f80f5ae52a05b4ab7b41af47 | ||
| DD-MM-YY. See http://labix.org/python-dateutil\ |
There was a problem hiding this comment.
don't split links. if a line starts as
# http://...
the pep8 tool should auto-skip the length check
There was a problem hiding this comment.
unfortunately it does not do this yet
There was a problem hiding this comment.
@thisch I think you just need to update your pep8. It seems to pass on travis and on my local machines.
There was a problem hiding this comment.
I'm using the latest pep8 code from git.
# a b c d e f http://labix.org/python-dateutil#head-b95ce2094d189a89f80f5ae52a05b4ab7b41af47pep8 outputs
/tmp/tmp.py:1:80: E501 line too long (93 > 79 characters)
|
I didn't know pep8 would skip those. Thanks, I learned something new. Updated to fix those. |
I've begin fixing up pep8 style errors and updating the test test_coding_standards to reflect the fixes