Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing matplotlib failing when pacakge "six" is 1.3.0 #3538

Closed
djunderw opened this issue Sep 18, 2014 · 14 comments
Closed

Importing matplotlib failing when pacakge "six" is 1.3.0 #3538

djunderw opened this issue Sep 18, 2014 · 14 comments
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Milestone

Comments

@djunderw
Copy link

This issue is based on the folllowing SO question:

http://stackoverflow.com/questions/25920510/python-matplotlib-not-importing-due-to-failure-to-import-unichr

matplotlib fails to be imported when the package "six" is version 1.3.0.

@WeatherGod
Copy link
Member

I am pretty sure this is already fixed. Heck, I think I was the one who reported it a year ago. We bumped the minimum required version for six from 1.3 to 1.4 to accomodate the unichr() function or something like that.

@tacaswell
Copy link
Member

@tacaswell tacaswell added this to the v1.4.1 milestone Sep 18, 2014
@WeatherGod
Copy link
Member

Yeah... take a peek at blame...

You changed it from 1.5 to 1.3 back in March.

On Thu, Sep 18, 2014 at 4:10 PM, Thomas A Caswell notifications@github.com
wrote:

https://github.com/matplotlib/matplotlib/blob/master/setupext.py#L1179


Reply to this email directly or view it on GitHub
#3538 (comment)
.

@WeatherGod
Copy link
Member

See this commit by @mdboom :
e1053a6

I wish there was a way to know which PR pulled in a particular commit.

On Thu, Sep 18, 2014 at 4:14 PM, Benjamin Root ben.v.root@gmail.com wrote:

Yeah... take a peek at blame...

You changed it from 1.5 to 1.3 back in March.

On Thu, Sep 18, 2014 at 4:10 PM, Thomas A Caswell <
notifications@github.com> wrote:

https://github.com/matplotlib/matplotlib/blob/master/setupext.py#L1179


Reply to this email directly or view it on GitHub
#3538 (comment)
.

@jenshnielsen
Copy link
Member

Looking at the history it was changed back a few days later 197d794

@tacaswell
Copy link
Member

if you search on the has it will find the PR

#2879

@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 18, 2014
@WeatherGod
Copy link
Member

I knew I reported something like this awhile back! I wonder why your
experimental build/testing worked at that time? Maybe the use of unichr()
snuck in afterwards?

Do our Travis tests use the minimum packages? We probably could have caught
this earlier, I think.

On Thu, Sep 18, 2014 at 4:33 PM, Thomas A Caswell notifications@github.com
wrote:

if you search on the has it will find the PR

#2879 #2879


Reply to this email directly or view it on GitHub
#3538 (comment)
.

tacaswell added a commit to tacaswell/matplotlib that referenced this issue Sep 18, 2014
 turns out we really need version 1.4 or better

fixes matplotlib#3538
@tacaswell
Copy link
Member

six.unichr was first used in a00196b (may) so 1.3 was ok in march. Apparently either fixed my path issues or ubuntu updated what they shipped in between.

@WeatherGod #2852 this the issue that induced the first minimum version to be added.

Not sure what version travis uses, probably what ever is on the system.

@tacaswell
Copy link
Member

And we have now spent at least a factor of 5 more time discussing this than it took to fix;)

@pelson
Copy link
Member

pelson commented Sep 23, 2014

I wish there was a way to know which PR pulled in a particular commit.

@WeatherGod - Put the commit into the search bar when in matplotlib/matplotlib - all issues which refer will be returned, including the PR that implemented it...

You're welcome 😉

@mmeanwe
Copy link

mmeanwe commented Oct 28, 2014

Hi folks - upgraded six, still throwing following error: ' from six import unichr
ImportError: cannot import name unichr' - any ideas? Version is six-1.8.0 for python 2.7

@efiring
Copy link
Member

efiring commented Oct 28, 2014

In [2]: from six import unichr

In [3]: six.__version__
'1.8.0'

Sounds like the version of six you upgraded to is not the version that is being found.

@mmeanwe
Copy link

mmeanwe commented Oct 29, 2014

Thanks - imported another six.py file and that seemed to do it. Matplotlib
seems a bit buggy at first, but up and running now.
On Oct 27, 2014 9:37 PM, "Eric Firing" notifications@github.com wrote:

In [2]: from six import unichr
In [3]: six.version'1.8.0'

Sounds like the version of six you upgraded to is not the version that is
being found.


Reply to this email directly or view it on GitHub
#3538 (comment)
.

@jenshnielsen
Copy link
Member

Do you have any specific issues apart for the six version issue?
If so please open a new issue with the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

No branches or pull requests

7 participants