Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Cannot pick empty vline #3591

Closed
wants to merge 67 commits into from
Closed

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Sep 29, 2014

I tried to create a picker on an empty vline. This seems to not work but I have used this before I think with other lines, so thought that it should. I guess I will just not use vlines for now.

In [1]: from matplotlib import pyplot as plt

In [2]: import matplotlib

In [3]: matplotlib.__version__
Out[3]: '1.3.1'

In [4]: vl = plt.vlines([], 0, 1, picker=8)

In [5]: plt.show()  # Now press anywhere into the axis
Floating point exception (core dumped)

From GDB:

Program received signal SIGFPE, Arithmetic exception.
0x00007fffe48979d0 in _path_module::point_in_path_collection(Py::Tuple const&) ()
   from /usr/lib/pymodules/python2.7/matplotlib/_path.so

tacaswell and others added 30 commits September 3, 2014 16:23
Due to scoping fixes in py3k, list comprehensions over class level
attributes during class definition does not work (see
http://stackoverflow.com/questions/13905741/accessing-class-variables-from-a-list-comprehension-in-the-class-definition).

Superficially Fixes matplotlib#3436. There seem to be other issues
minimum version for freetype is 2.3

closes matplotlib#3412
When formatting the png data to send over the wire need to decode the
byte string to ascii.  If this is not done the literal string sent
to the browser is:
   "data:image/png;base64,b'iVBOR...'"
instead of
   "data:image/png;base64,iVBOR..."

The extra b' makes the string no longer a valid png which is why
we were getting white boxes
_get_clip_path was returning '<built-in function id>' instead
of the ps-function name like it should have been.  This was introduced
in 9b9c0c6 in PR matplotlib#2927.

Closes matplotlib#3523
BUG : fix eps corruption when using clipping
…hould

silence most warnings in the html only small build on travis
BUG : use getcwdu to deal with unicode in user home-path in python 2
BUG : Only insert links to pdfs if we are actually generating these.
 - moved logic to parse sym from bxp -> boxplot
 - restored documented behavior with `sym=''`
 - change default value of sym from 'b+' -> None
   - should not be visible from outside as default behavior remains
     the same

closes matplotlib#3459
Changed to be True to match the code

closes matplotlib#3455
BUG : Added legend.framealpha to rcParams, as mentioned in axes.legend docstring
BUG/DOC : Correct default value listed in docstring
Restore the value of `whis` to the input value at the top of each pass
through the for-loop.

@WeatherGod hit the nail on the head.

closes matplotlib#3468
BUG : fixes whis over-writing in boxplot_stats
 turns out we really need version 1.4 or better

fixes matplotlib#3538
tacaswell and others added 20 commits September 22, 2014 11:55
…rror_message

MNT : Provide an informative error message if something goes wrong in setfont
MNT : Typo in comment documentation for example timers.py
TST : Install texlive and other dependencies when building docs.
If the user does not pass in a label, do not assign one.

Fixes matplotlib#3563
if the new style introspection GObject python bindings are in use.  With
pygobject >= 3.13.4 the following:

    from gi.repository import GObject
    from matplotlib import pyplot

causes an exception to be raised:

> AttributeError: When using gi.repository you must not import static modules
> like "gobject". Please change all occurrences of "import gobject" to "from
> gi.repository import GObject". See:
> https://bugzilla.gnome.org/show_bug.cgi?id=709183

It is not valid to use both non-introspection based and introspection based
PyGObject in the same process.  Backend probing will `import gobject` (i.e. the
non-introspection bindings) if it sees that the 'gtk' module is loaded.
Unfortunately it wouldn't check if this was the pygi or old-style gtk module.
This commit adds this check avoiding the exception.

This check was added to PyGObject in [d704033][1]

[1]: https://git.gnome.org/browse/pygobject/commit/?id=d704033
 - added check that labels don't get adding by default
If a data list is empty, return a dict full of np.nan.

Closes matplotlib#3569 and addresses part of
pandas-dev/pandas#8382
BUG : Ticks on top axis disappear if tick size is too large (when using bbox_inches='tight')
BUG : fix handling of flierprop by boxplot
BUG : deal with empty list passed to boxplot
Fixed the differencing of images for the webagg/nbagg backends.
BUG : don't assume label in boxpplot_stat
@seberg
Copy link
Contributor Author

seberg commented Sep 29, 2014

Actually I found a more fun workaround. I just draw a vline with NaN :)

@mdboom
Copy link
Member

mdboom commented Sep 29, 2014

In any event, I think this is a legit bug. I'll see if I can find a solution.

@mdboom mdboom self-assigned this Sep 29, 2014
@mdboom mdboom added this to the v1.4.1 milestone Sep 29, 2014
@mdboom
Copy link
Member

mdboom commented Sep 29, 2014

Oh crap. I accidentally made this against the wrong branch. Closing and making a new one...

@mdboom mdboom closed this Sep 29, 2014
@mdboom
Copy link
Member

mdboom commented Sep 29, 2014

See #3592.

@mdboom mdboom deleted the picking-empty branch March 3, 2015 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants