Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs require skimage #3685

Closed
mdboom opened this issue Oct 20, 2014 · 4 comments
Closed

Docs require skimage #3685

mdboom opened this issue Oct 20, 2014 · 4 comments
Milestone

Comments

@mdboom
Copy link
Member

mdboom commented Oct 20, 2014

Three examples now require it, for the rgb2lab function:

users/plotting/colormaps/lightness.py
5:from skimage import color

users/plotting/colormaps/Lfunction.py
9:from skimage import color

users/plotting/colormaps/grayscale.py
6:from skimage import color

We should probably just subsume rgb2lab -- skimage is a fairly heavy dependency just for this.

@jenshnielsen
Copy link
Member

Yes, I was trying to fix all the Sphinx warnings on Travis but never got round to this one. It is even more problematic since this part of skimage depends on scipy too.

I was planing to just deploy the dependencies with miniconda, but skimage also depends on matplotlib so we could easily create circular dependencies.

@mdboom
Copy link
Member Author

mdboom commented Oct 20, 2014

Yeah -- but for just converting RGB to LAB, we shouldn't need all that, see, for example:

https://stackoverflow.com/questions/13405956/convert-an-image-rgb-lab-with-python

@jenshnielsen
Copy link
Member

Cool that is probably a better solution given the issues above.

@jenshnielsen
Copy link
Member

fixed by #3737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants