Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pep8 tests are not really running but reporting success #4720

Closed
tacaswell opened this issue Jul 17, 2015 · 4 comments
Closed

pep8 tests are not really running but reporting success #4720

tacaswell opened this issue Jul 17, 2015 · 4 comments
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: testing
Milestone
v1.5.0

Comments

@tacaswell
Copy link
Member

see: https://travis-ci.org/matplotlib/matplotlib/jobs/71292068

attn @jenshnielsen as the poor soul who is the testing expert

I am starting to think we should roll back #4668 and #4708
@tacaswell
Copy link
Member Author

@HolgerPeters Any suggestions?

@tacaswell tacaswell added this to the next point release milestone Jul 17, 2015
@tacaswell tacaswell added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: testing labels Jul 17, 2015
@tacaswell tacaswell mentioned this issue Jul 17, 2015
Merged
jenshnielsen added a commit to jenshnielsen/matplotlib that referenced this issue Jul 17, 2015
@jenshnielsen
Travis: Revert to using tests.py. Temp fix for matplotlib#4720
0debe77
@jenshnielsen
Copy link
Member

tests.py is still there and I think it still works. So we should be able to buy some time time by just reverting Travis to run tests.py again.

I have opened a PR to do that. #4723

@jenshnielsen
Copy link
Member

I happy to look more into this. However I am traveling back to the UK tomorrow so I will be cut of from the internet

@jenshnielsen jenshnielsen mentioned this issue Jul 17, 2015
Merged
tacaswell added a commit that referenced this issue Jul 17, 2015
@tacaswell
Merge pull request #4723 from jenshnielsen/Travistests
ed196c6 
Travis: Revert to using tests.py. Temp fix for #4720
@tacaswell
Copy link
Member Author

Fixed by #4723

@jenshnielsen jenshnielsen mentioned this issue Nov 8, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: testing
Projects
None yet
Milestone
v1.5.0
Development

No branches or pull requests
2 participants
@tacaswell @jenshnielsen