Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"prop_cycle" or "prop_cycler" in ver 1.5.0.rc2? #5175

Closed
thomas-haslwanter opened this issue Oct 3, 2015 · 7 comments
Closed

"prop_cycle" or "prop_cycler" in ver 1.5.0.rc2? #5175

thomas-haslwanter opened this issue Oct 3, 2015 · 7 comments
Milestone

Comments

@thomas-haslwanter
Copy link

The docu for the API-changes in 1.5.0 claims that
"axes.color_cycle"
will be replaced by
"axes.prop_cycle"
However, the implementation in 1.5.0.rc2 uses
"axes.prop_cycler"

I don't know which version would be preferable.

@tacaswell tacaswell added this to the next point release (1.5.0) milestone Oct 3, 2015
@tacaswell
Copy link
Member

Trust the code!

attn @WeatherGod

@WeatherGod
Copy link
Member

Oh, crap. It was supposed to be prop_cycle. So, which do we want to fix?

On Sat, Oct 3, 2015 at 2:07 PM, Thomas A Caswell notifications@github.com
wrote:

Trust the code!

attn @WeatherGod https://github.com/WeatherGod


Reply to this email directly or view it on GitHub
#5175 (comment)
.

@tacaswell
Copy link
Member

If we fix the code, we need to reach out pandas ASAP @TomAugspurger

@TomAugspurger
Copy link
Contributor

I'll follow along here. We're doing our release on Friday.

Not that it should affect anything but I look for prop_cycle. I do prefer prop_cycle to prop_cycler.

@WeatherGod
Copy link
Member

git grep axes.prop_cycler yields no matches. Where are you seeing
axes.prop_cycler in the code implementation? Note that there is the
Axes._get_lines.prop_cycler and such, but those are considered private
and should not be accessed outside of matplotlib.

On Mon, Oct 5, 2015 at 11:04 AM, Tom Augspurger notifications@github.com
wrote:

I'll follow along here. We're doing our release on Friday.

Not that it should affect anything but I look for prop_cycle. I do prefer
prop_cycle to prop_cycler.


Reply to this email directly or view it on GitHub
#5175 (comment)
.

@thomas-haslwanter
Copy link
Author

As you have stated correctly, I have only seen it in the "Axes._get_lines_prop_cycler".
This was not my own code. But I thought I'd report it anyway.

@WeatherGod
Copy link
Member

Ah, I see. Well, the rcparam names do not have to align with the names used in the code. So, I'll close this issue. Do let us know if you see anything else that seems inconsistent to you, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants