Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_backend.pgf.check_for(texsystem) does not do what it says... #5921

Closed
jankatins opened this issue Jan 26, 2016 · 4 comments
Closed

test_backend.pgf.check_for(texsystem) does not do what it says... #5921

jankatins opened this issue Jan 26, 2016 · 4 comments
Milestone

Comments

@jankatins
Copy link
Contributor

def check_for(texsystem): #<- different commands are asked for, but not actually checked below...
    header = """
    \\documentclass{minimal}
    \\usepackage{pgf}
    \\begin{document}
    \\typeout{pgfversion=\\pgfversion}
    \\makeatletter
    \\@@end
    """
    try:
        latex = subprocess.Popen(["xelatex", "-halt-on-error"], #<- why not texsystem? 
                                 stdin=subprocess.PIPE,
                                 stdout=subprocess.PIPE)
        stdout, stderr = latex.communicate(header.encode("utf8"))
    except OSError:
        return False

    return latex.returncode == 0

Not sure if thats on purpose, but if so it should be documented...

@jenshnielsen
Copy link
Member

I think this is a bug. I have fixed it as part of #5727 which still waits for Travis to approve cm-super before it can be merged.

@jenshnielsen
Copy link
Member

@pwuertz does the change in 7d67737 make sense to you?

@pwuertz
Copy link
Contributor

pwuertz commented Feb 8, 2016

Right, this is a bug/typo in check_for()

@jenshnielsen
Copy link
Member

fixed in #5727

@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants