Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced hillshading example looks strange with new defaults. #6043

Closed
jenshnielsen opened this issue Feb 22, 2016 · 4 comments
Closed

Advanced hillshading example looks strange with new defaults. #6043

jenshnielsen opened this issue Feb 22, 2016 · 4 comments
Assignees
Milestone

Comments

@jenshnielsen
Copy link
Member

Compare:
http://matplotlib.org/devdocs/examples/specialty_plots/advanced_hillshading.html
to
http://matplotlib.org/examples/specialty_plots/advanced_hillshading.html

This is likely related to the change in blend mode

@jenshnielsen jenshnielsen added this to the 2.0 (style change major release) milestone Feb 22, 2016
@mdboom
Copy link
Member

mdboom commented Feb 29, 2016

I think there's actually two style changes affecting this: the change of blend_mode from hsv to overlay, and the change of interpolation from bilinear to nearest.

As to how to fix: does it make sense to just explicitly pass the old defaults to restore the old behavior?

@jenshnielsen jenshnielsen self-assigned this Feb 29, 2016
@jenshnielsen
Copy link
Member Author

Yes probably I will investigate it

@tacaswell
Copy link
Member

@njsmith Can you comment on this one? I think the change was at your request.

@njsmith
Copy link

njsmith commented Mar 21, 2016

Unfortunately I know nothing about hill shading, my only contribution was to point out that the source code had a comment saying that the default was unfortunate and should be changed when possible. I'd look to see who wrote that comment I guess :-)

jenshnielsen added a commit to jenshnielsen/matplotlib that referenced this issue May 22, 2016
In general no interpolation is the best soloution but in this case shading works better with interpolation.
Closes matplotlib#6043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants