Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 beta: Boxplot patches zorder differs from lines #6510

Closed
Tillsten opened this issue May 31, 2016 · 4 comments
Closed

2.0 beta: Boxplot patches zorder differs from lines #6510

Tillsten opened this issue May 31, 2016 · 4 comments
Assignees
Milestone

Comments

@Tillsten
Copy link
Contributor

See the example from the devdocs:

http://matplotlib.org/devdocs/examples/statistics/boxplot_color_demo.html

The patches are behind the grid while the lines are in front of it.
Maybe patches should be in front of grid by default also, which i
think is the more common case.

@tacaswell tacaswell added this to the 2.0 (style change major release) milestone May 31, 2016
@efiring
Copy link
Member

efiring commented Jun 19, 2016

@Tillsten would you like to submit a PR? I think there are two possible ways to address it: either make the default grid lines zorder below patches and then explicitly set the zorder for filled contours (patch collections) and probably others to be above, or leave the default grid lines zorder where it is and elevate the boxplot patches. My preference is for the second option because I suspect that there will be common cases in addition to filled contours (bar plots? Histograms? Step-filled plots?) where having the patches above the grid will not be what users intend.
Part of the problem here is that the switch from dashed to solid grid lines made them more prominent and obtrusive. That is the reason I moved them behind lines. My rationale for leaving them above patches was that patches are often big (or cover everything, as in the contourf case), so putting the grid behind them would defeat the purpose of having a grid. This is also the reason that the grid is above images.

tacaswell added a commit to tacaswell/matplotlib that referenced this issue Jul 16, 2016
@tacaswell tacaswell self-assigned this Jul 16, 2016
tacaswell added a commit to tacaswell/matplotlib that referenced this issue Jul 25, 2016
Add a small delta to the mean and median lines to ensure that they are
on top.

closes matplotlib#6510
@jenshnielsen
Copy link
Member

fixed by #6766

@tacaswell
Copy link
Member

attn @Tillsten do you agree that this is fixed?

@Tillsten
Copy link
Contributor Author

Yes, would have totally do the same, set eqaul zorder with small delta!

story645 pushed a commit to story645/matplotlib that referenced this issue Aug 17, 2016
Add a small delta to the mean and median lines to ensure that they are
on top.

closes matplotlib#6510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants