Colormap byteorder bug #1095
Merged
Colormap byteorder bug #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1005.
I considered trying to work around the underlying putmask problem by modifying our _putmask, but concluded this was more trouble than it was worth; the bug seems to involve only the most special and obscure circumstances, which we happened to be triggering when substituting the number slightly less than unity for values of 1.0, and only when the input byte order is not native.
The solution in this pull request is to change the byte order to native before proceding with the putmask and other calculations in the Colormap.call() method