Fixed transoffset example from failing. #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| resolution = kwargs.pop('resolution', 1) | ||
| ax = gca(polar=True, resolution=resolution) |
There was a problem hiding this comment.
This part wasn't necessary, but is out of date and redundant. I would be willing to put it back in if requested.
|
Looks good. |
|
Merging. |
mdboom
added a commit
that referenced
this pull request
Aug 21, 2012
Fixed transoffset example from failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue came about because the polar axes which had already been created via
plt.subplotwasn't getting picked up with a simpleplt.gca(projection='polar')due to different gridspecs. I have removed the use of the gridspec in the key comparison of gca, and added a few tests which cover these changes.Fixes #1084.