workaround for fixed dpi assumption in adjust_bbox_pdf #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is good for 1.2 release. As soon as we have 1.2 out, let's remove "adjust_bbox_pdf" and see if it works. |
mdboom
added a commit
that referenced
this pull request
Aug 28, 2012
workaround for fixed dpi assumption in adjust_bbox_pdf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving figures with
bbox_inches='tight', the functionadjust_bbox_pdfwhich is used for rescaling and repositioning the figure assumes a fixed dpi of 72. The pgf backend leaves figure.dpi up to the user for defining the resolution of images. This PR is a workaround for PGF figures being handled incorrectly inadjust_bbox_pdfuntil we find out why the 72 dpi assumption was necessary (fixes #1135).