Subplot.twin[xy] returns a Subplot instance #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't affect any of the regression tests, but I think it would be worth noting the API change in the |
| ax2 = self.figure.add_axes(self.get_position(True), *kl, **kwargs) | ||
| return ax2 | ||
|
|
||
|
|
There was a problem hiding this comment.
I know its picky, but would you mind putting 1 newline between methods and 2 newlines between top level classes/functions.
|
+1 from me. Seems like a sensible solution to the problem. |
efiring
added a commit
that referenced
this pull request
Sep 2, 2012
Subplot.twin[xy] returns a Subplot instance
|
The white-space fixes can be done later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #1165.
Not sure if there will be some regression issue as its return type is different.