FIX undefined elements were used at several places in the mlab module #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2780,6 +2772,8 @@ def griddata(x,y,z,xi,yi,interp='nn'): | |||
| if xi.ndim == 1: | |||
| xi,yi = np.meshgrid(xi,yi) | |||
| # triangulate data | |||
| # FIXME delaunay is not imported here, and depends on the | |||
| # scipy.spatial packages; Scipy is not a dependency of matplotlib. | |||
| tri = delaunay.Triangulation(x,y) | |||
There was a problem hiding this comment.
Delunay is a mpl sub-package, not the scipy delunay. However, there should be an absoute import of the package, i.e. import matplotlib.delunay rather than a relative one (can you check that for me?).
There was a problem hiding this comment.
Correct. I don't know how I could have missed it... I've deleted the FIXME
|
Looks good. |
efiring
added a commit
that referenced
this pull request
Sep 1, 2012
FIX undefined elements were used at several places in the mlab module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were undefined elements in the mlab module. it seems like this module is quite old and not very well tested in terms of coverage; It's also probably not widely used. I've fixed some of the problems but it might be worth it to do a huge clean up in the near future.