Small bugfixes to the new pickle support. #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,7 +11,11 @@ | |||
| import cPickle as pickle | |||
| #import pickle | |||
|
|
|||
| from cStringIO import StringIO | |||
| import sys | |||
| if sys.version_info[0] >= 3: | |||
There was a problem hiding this comment.
I've still not tested this, I took the lead from mathtext.py. Hopefully travis-ci will be helpful here.
|
So I had a python3 extension to fix test_pickle in this PR. My approach wasn't immediately successful so I backtracked and have simplified this PR to just make this critical pgf fix. Other PRs to follow. |
pelson
added a commit
that referenced
this pull request
Sep 2, 2012
Small bugfixes to the new pickle support.
|
About that python3 test fix: The io module has been introduced in python 2.6, so the fix should be good for all supported versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pickling support (#1175) finally made it onto master. We merged early to avoid major conflicts with such a big PR, therefore this PR implements some of the identified issues.