PEP8 fixes on table.py #1376
Merged
PEP8 fixes on table.py #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -276,6 +281,7 @@ def get_children(self): | |||
| def get_window_extent(self, renderer): | |||
| 'Return the bounding box of the table in window coords' | |||
| boxes = [c.get_window_extent(renderer) for c in self._cells] | |||
| # FIXME bbox_all is not defined | |||
| return bbox_all(boxes) | |||
There was a problem hiding this comment.
Hmmm, I wonder if this method is used...
There was a problem hiding this comment.
According to doc/api/api_changes.rst, bbox_all() should be changed to Bbox.union()
There was a problem hiding this comment.
I could fix that, but IMO it is better to open a ticket (easyfix tagged?), and have someone do a proper regression tests on it.
There was a problem hiding this comment.
Done. Issue #1385 is tagged low_hanging_fruit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP8 fixes on the module table.
Thanks,
N.