backend_pdf: optional rgbFace arg in fillp replaces code in draw_markers. Closes #1410 #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plotlib into mdboom-transparent_pdf_markers Upstream PR was based on slightly earlier commit on v1.2.x.
|
Cheers @efiring. +1 |
|
I think this should be merged, but I'd at least like approval from @mdboom first. |
|
I agree -- I think this is preferable. |
|
Ok, great. I'll merge this by the end of today (Blighty Time). |
Does anybody else know what this is other than us Brits (who have listened to Terry Wogan)? 😃 |
dmcdougall
added a commit
that referenced
this pull request
Oct 22, 2012
backend_pdf: optional rgbFace arg in fillp replaces code in draw_markers. Closes #1410
|
@pelson I think it's my way of refusing to get over the fact he no longer does the Eurovision Song Contest. |
|
On Monday, October 22, 2012, Damon McDougall wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modification of #1411, taking advantage of the test case and image files, but using the alternative method of fixing the bug that I suggested in the #1411 discussion. It seems to me like a cleaner solution, but this may be just a matter of taste. Or I might be wrong.