PEP8-compliance on axes.py (patch 4 / 4) #1564
Merged
+137
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if marker is None: | ||
| marker = 's' | ||
| if markersize is None: | ||
| markersize = 10 |
There was a problem hiding this comment.
Hmm, magic numbers like this are probably dealt with a better way. Not suggesting it is fixed in this PR, just thought I would point it out.
|
+1 |
| @@ -8152,19 +8159,20 @@ def hist(self, x, bins=10, range=None, normed=False, weights=None, | |||
| # We will handle the normed kwarg within mpl until we | |||
| # get to the point of requiring numpy >= 1.5. | |||
| hist_kwargs = dict(range=bin_range) | |||
| if np.__version__ < "1.3": # version 1.1 and 1.2 | |||
| if np.__version__ < "1.3": # version 1.1 and 1.2 | |||
There was a problem hiding this comment.
For another PR: The numpy minimum version for mpl 1.2 is 1.4, so we can remove this.
There was a problem hiding this comment.
I'm working on a PR to remove deprecated stuff from this module; There's also something that was deprecated in 2010. I'm guessing that could also be removed (it was in 0.99).
|
👍 |
pelson
added a commit
that referenced
this pull request
Dec 6, 2012
PEP8-compliance on axes.py (patch 4 / 4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the last patch on the pep8 compliance of the axes.py module.
Cheers,
N