New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to Sankey class #1574
Conversation
print "ulpath\n", self._revert(ulpath) | ||
print "urpath\n", urpath | ||
print "lrpath\n", self._revert(lrpath) | ||
print("llpath\n", llpath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a from __future__ import print_function
. We need to target py2.x when we code, and allow for 2to3 to take care of any py3k issues for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I included this in commit 92575e2 below.
Besides the minor issues I have noted, this change seems mostly harmless and improves code readability and improves the docs a bit. |
This is fine. +1. |
Improvements to Sankey class
The changes are mostly minor--fixed typos, some docstring reformatting, adjusted figure size in a demo. The most significant change is to the way that path labels are handled. The label strings are now copied properly so that they aren't modified by reference.