Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Sankey class #1574

Merged
merged 7 commits into from Dec 7, 2012
Merged

Conversation

kdavies4
Copy link
Contributor

@kdavies4 kdavies4 commented Dec 7, 2012

The changes are mostly minor--fixed typos, some docstring reformatting, adjusted figure size in a demo. The most significant change is to the way that path labels are handled. The label strings are now copied properly so that they aren't modified by reference.

print "ulpath\n", self._revert(ulpath)
print "urpath\n", urpath
print "lrpath\n", self._revert(lrpath)
print("llpath\n", llpath)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a from __future__ import print_function. We need to target py2.x when we code, and allow for 2to3 to take care of any py3k issues for us.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I included this in commit 92575e2 below.

@WeatherGod
Copy link
Member

Besides the minor issues I have noted, this change seems mostly harmless and improves code readability and improves the docs a bit.

@dmcdougall
Copy link
Member

This is fine. +1.

WeatherGod added a commit that referenced this pull request Dec 7, 2012
Improvements to Sankey class
@WeatherGod WeatherGod merged commit 3e6e735 into matplotlib:master Dec 7, 2012
@dmcdougall dmcdougall mentioned this pull request Dec 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants