New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix "alpha" kwarg in errorbar plot #1675
Conversation
- this patch was rightly proposed by Hans Dembinski on the matplotlib devel mailing list but never incorporated it seems
Seems fine to me. Is there an existing test which could make use of the new/fixed functionality? |
I am not really familiar with the testing scheme. It seems the tests compare against saved plot files as seen in the gallery? These do not contain alpha values (otherwise this bug would have surfaced much earlier). I guess that would mean using an alpha value in one of the example plots then? |
The tests would test alpha at this level. The only thing the tests don't do is test for alpha that "bleeds" all the way through to transparent parts of the figure itself. In some formats, such as PDF, this isn't even possible anyway. But I think what would be best here would be to modify one of the errorbar tests to use alpha on some element or other. That should then catch this bug. |
Yes, I will adapt one of the tests, no problem. |
Ok, @dmcdougall, should be OK now. |
@megies |
Sorry I misread your question. My above suggestion runs a single file. To run a single test you do: $ python tests.py matplotlib.tests.test_axes:test_errorbar |
The py26 error is a dud; merging. Thanks @megies. |
fix "alpha" kwarg in errorbar plot
Thanks for the info. Glad to help. |
This patch was rightly proposed by Hans Dembinski on the matplotlib
devel mailing list but never incorporated it seems.