PEP8 fixes on the figure module #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -346,9 +349,9 @@ def show(self, warn=True): | |||
| try: | |||
| manager = getattr(self.canvas, 'manager') | |||
| except AttributeError as err: | |||
| raise AttributeError("%s\n Figure.show works only " | |||
There was a problem hiding this comment.
This \n nicely separates the error message from the rest of the message:
AttributeError: 'FigureCanvasPdf' object has no attribute 'manager'
Figure.show works only for figures managed by pyplot,
normally created by pyplot.figure().Is it bad practice to leave new line characters in the middle of strings like this?
There was a problem hiding this comment.
I think it's fine to have the \n left in -- it certainly improves the output. Maybe the middle ground is to also put the string breaks in the same place, eg:
raise AttributeError(
"%s\n"
"Figure.show works only for figures managed by pyplot,\n"
"normally created by pyplot.figure()." % err)
There was a problem hiding this comment.
I've added it back. In general, doing formatting of error messages "manually" isn't a good thing. Here, I agree it is better to separate the original error message to the more understandable matplotlib one.
efiring
added a commit
that referenced
this pull request
Feb 18, 2013
PEP8 fixes on the figure module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a small patch for pep8 fixes on the figure module.
Thanks,
N