New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed handling of bar(.., bottom=None, log=True)
#1889
Conversation
build errors are inkscape installation errors. |
I fixed the install errors in 01a4bed. Sorry to go behind protocol on that commit; I used the GitHub editor and I thought it would make a pull request out of it rather than commit directly to the repository. |
the case of `log=True`. If this is not done, there will be type exceptions. Issue matplotlib#1882
@dmcdougall ok, rebased. |
I think I introduced this bug. Can we get a test so it doesn't happen again? |
@neggert Can you write that test (I am super swamped, have a committee meeting in a week)? I don't think we need an image test for this, just make sure all reasonable arguments don't blow up. Can you also take a look at the other issues @y-p has brought up in the original issue thread? @dmcdougall do you want me to rebase this again to get all of the svg tests to run? |
I can do the test, but it might take me a few days to get to it. I propose to merge this now. I'll make a separate PR with the test when I get to it. |
@@ -4797,6 +4797,7 @@ def make_iterable(x): | |||
if _bottom is None: | |||
if self.get_yscale() == 'log': | |||
adjust_ylim = True | |||
bottom = [1e-100] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to move this outside of the if statement and just set it to [0]
. That was the reason for making the change (nonposy=True
) that got this all started. That way it will behave well even if someone wants to work with very small numbers.
@neggert Done. I suspected that would be the case, but went with what seemed to be the minimal change (which was replacing those lines) |
@neggert Do you agree with how this is fixed now? |
Yup! Thanks. On Mon, Apr 15, 2013 at 10:21 AM, Thomas A Caswell
|
@mdboom Can this be merged? |
Fixed handling of `bar(.., bottom=None, log=True)`
re-added lines to make sure that
bottom
andleft
are not None in the case oflog=True
. If this is not done, there will be type exceptions.Issue #1882