New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
texmanager doesn't handle list of names for font.family
#2012
Conversation
…ll pass when font.family is a list of strings (though there's no sane way for LaTeX to deal with that, but that's nothing new).
Seems ok to me. My only critique is that it seems like the font system is being squeezed here to support something it wasn't originally designed for - is there an issue to raise this as a topic of a MEP for v1.4 (in my head I thought I'd seen one somewhere)? |
elif family1 == family2: | ||
return 0.0 | ||
return 0.1 * float(i) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a bit magic to me, but I can live with it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. float(i) / float(len(families))
would be less magical. I'll change it to that.
I agree that the font system could probably use some new polish. The font system has supported selecting fonts by a list of family names for a very long time -- it's just that it's now be exposed to the rcParam level. The real problem here, in my opinion, is that the same parameters are being overloaded for use by the built-in font system and the LaTeX font system and they (necessarily) have very different semantics on how they handle things. This should probably be split into 3 things (somehow) -- a common interface that "does the right thing" in both contexts, and then separate things for more detailed control of each text type. I've thought for a long time that what we need is the concept of pluggable text backends so we could have the built-in matplotlib one, LaTeX, Pango, Apple and other text rendering infrastructure selectable and individually configurable -- but, yes, that's definitely a MEP-level discussion. |
texmanager doesn't handle list of names for `font.family`
No description provided.