Deprecations and housecleaning #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,7 @@ | |||
| #### CONFIGURATION BEGINS HERE | |||
|
|
|||
| # the default backend; one of GTK GTKAgg GTKCairo GTK3Agg GTK3Cairo | |||
| # CocoaAgg FltkAgg MacOSX QtAgg Qt4Agg TkAgg WX WXAgg Agg Cairo GDK PS | |||
| # CocoaAgg FltkAgg MacOSX Qt4Agg TkAgg WX WXAgg Agg Cairo GDK PS | |||
There was a problem hiding this comment.
FltkAgg is also removed, so it needs to be deleted from this comment.
|
Wow! Thanks for putting all that together. It looks like the test failure with 2.6 is completely unrelated. |
| since, message='', name='', alternative='', pending=False, | ||
| obj_type='attribute'): | ||
| """ | ||
| Used display deprecation warning in a standard way. |
|
@mdboom - I've added a couple of trivial actions. If you just add a commit on top of 85f1966 (or alternatively ammend the last commit, leaving 3dab377 static) I'd be happy to merge this ASAP. This will conflict with #2011 but given the size of this PR, I'm happy to have to resolve that conflict in my PR. Awesome! I think this is the best PR I've seen on mpl - I'm a big fan of deleting code 😄 |
pelson
added a commit
that referenced
this pull request
May 21, 2013
Major deprecations and housecleaning for v1.3
This was referenced May 21, 2013
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ties up a number of related issues:
This also brings over a helper function and decorator originally written by @iguananaut for the astropy project that makes it easier to mark functions as deprecated. This also unifies the interface for deprecated things and makes it easier to search later for things that are due for removal (that should make this kind of PR a little easier next time).