New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated coding standards test to raise an exception containing the PEP8 failiures. #2099
Conversation
Good for merge? |
Before merging, I'd like to test this right in Travis by introducing some PEP8 errors and making sure the output appears in the pep8 test's output section and not up above. |
Added a commit on top of 887d162 |
I'll remove the commit when we've seen the travis result. |
The test seems to be passing (even with your bad commit)... |
@@ -179,7 +179,7 @@ def byte2str(b): return b | |||
raise ImportError('matplotlib requires Python 2.4 or later') | |||
|
|||
|
|||
import numpy | |||
import numpy # This is a sneaky little comment. It really doesn't comply with the PEP8 guidelines... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, what was that for? I almost wrote that this wasn't pep8 before reading the comment...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see earlier comments. I wanted to introduce some PEP8 test failures.
@pelson: Should we revive this? First it needs a rebase, then we need to confirm that the bad PEP8 commit shows up in the Travis log. |
Sure thing. I'll do what I can this afternoon. |
Ok. Rebased. Hopefully I've left enough PEP8 failures in there to demonstrate it's working. I'll then fix those intentional (ahem) PEP8 problems. 😄 |
Great. The travis build failed: https://s3.amazonaws.com/archive.travis-ci.org/jobs/11514742/log.txt
I'll go ahead and tidy up these two failures, then I think we can go ahead and merge this in the next couple of hours @mdboom. |
Thanks. |
Updated coding standards test to raise an exception containing the PEP8 failiures.
Thanks -- I think this is working well on the 1.3.x branch. Unfortunately, on master, we have a whole bunch of PEP8 problems that have crept in. I think I'm just going to disable this temporarily over there to get us through the 1.3.1 release (to lessen the possibility of noise as I merge things back into master), and then resolve the PEP8 issues properly after that. I have created #2443 as a reminder. |
Closes #2091