New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebAgg performance improvements #2261
Conversation
@@ -296,8 +295,10 @@ def remove_web_socket(self, web_socket): | |||
self.web_sockets.remove(web_socket) | |||
|
|||
def refresh_all(self): | |||
for s in self.web_sockets: | |||
s.send_image() | |||
if len(self.web_sockets): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the len is spurious here...
All looks fine to me, though this is perhaps a little late in the day for v1.3.0... I guess that comes down to how many people have already tested the WebAgg backend vs how many will benefit from a faster experience. For me the latter holds more weight, but we have to acknowledge the exception to the rule.... |
I hadn't really intended this for 1.3.0 (I just tagged that release), but it makes sense for any eventual 1.3.1 so I didn't do it against master. |
There is a failing test on Python2.6 which may be relevant (I've not been doing enough mpl lately to know):
Other than that, this PR is a nice addition and gets my 👍 |
That test failure is fairly common, and as best I can tell seems to be related to a race condition in creating the font cache. I've been unable to find a fix, as I still can't reproduce it locally (even in my own Travis-based VM). I'm wondering if we should just disable the test for now. In any event, it's definitely unrelated to this change. |
No description provided.