Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAgg performance improvements #2261

Merged
merged 2 commits into from Aug 1, 2013
Merged

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Jul 30, 2013

No description provided.

@@ -296,8 +295,10 @@ def remove_web_socket(self, web_socket):
self.web_sockets.remove(web_socket)

def refresh_all(self):
for s in self.web_sockets:
s.send_image()
if len(self.web_sockets):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the len is spurious here...

@pelson
Copy link
Member

pelson commented Jul 31, 2013

All looks fine to me, though this is perhaps a little late in the day for v1.3.0... I guess that comes down to how many people have already tested the WebAgg backend vs how many will benefit from a faster experience. For me the latter holds more weight, but we have to acknowledge the exception to the rule....

@mdboom
Copy link
Member Author

mdboom commented Jul 31, 2013

I hadn't really intended this for 1.3.0 (I just tagged that release), but it makes sense for any eventual 1.3.1 so I didn't do it against master.

@pelson
Copy link
Member

pelson commented Aug 1, 2013

There is a failing test on Python2.6 which may be relevant (I've not been doing enough mpl lately to know):

======================================================================
FAIL: matplotlib.tests.test_backend_pdf.test_use14corefonts.test
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python2.6/lib/python2.6/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/travis/virtualenv/python2.6/lib/python2.6/site-packages/matplotlib-1.3.0rc5-py2.6-linux-x86_64.egg/matplotlib/testing/decorators.py", line 40, in failer
    result = f(*args, **kwargs)
  File "/home/travis/virtualenv/python2.6/lib/python2.6/site-packages/matplotlib-1.3.0rc5-py2.6-linux-x86_64.egg/matplotlib/testing/decorators.py", line 159, in do_test
    '(RMS %(rms).3f)'%err)
ImageComparisonFailure: images not close: /home/travis/build/mdboom/tmp_test_dir/result_images/test_backend_pdf/pdf_use14corefonts_pdf.png vs. /home/travis/build/mdboom/tmp_test_dir/result_images/test_backend_pdf/pdf_use14corefonts-expected_pdf.png (RMS 43.667)

Other than that, this PR is a nice addition and gets my 👍

@mdboom
Copy link
Member Author

mdboom commented Aug 1, 2013

That test failure is fairly common, and as best I can tell seems to be related to a race condition in creating the font cache. I've been unable to find a fix, as I still can't reproduce it locally (even in my own Travis-based VM). I'm wondering if we should just disable the test for now. In any event, it's definitely unrelated to this change.

mdboom added a commit that referenced this pull request Aug 1, 2013
@mdboom mdboom merged commit 48fdef5 into matplotlib:v1.3.x Aug 1, 2013
@mdboom mdboom deleted the webagg-improvements branch August 7, 2014 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants