Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed colorbar outline from a Line2D object to a Polygon object #2352

Merged
merged 3 commits into from Aug 29, 2013

Conversation

tacaswell
Copy link
Member

fixes issue #2296

self.outline = lines.Line2D(
xy[:, 0], xy[:, 1], color=mpl.rcParams['axes.edgecolor'],
linewidth=mpl.rcParams['axes.linewidth'])
self.outline = mpatches.Polygon(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default zorder is 2 for Line2D and 1 for Patch objects, so maybe the zorder should be explicitly set to 2 here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@pelson
Copy link
Member

pelson commented Aug 28, 2013

Obviously, as an API change, this will need some documentation, but other than that I have no hold-ups from switching from Line2D to Polygon. 👍

@tacaswell
Copy link
Member Author

I guess this answers my question of if this really should have targeted 1.3.x instead of master.

added entry to api_changes.rst

dmcdougall added a commit that referenced this pull request Aug 29, 2013
changed colorbar outline from a Line2D object to a Polygon object
@dmcdougall dmcdougall merged commit 89e53aa into matplotlib:master Aug 29, 2013
@tacaswell tacaswell deleted the colorbar_outline_fix branch September 11, 2013 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants