New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set locale for tests #2368
Set locale for tests #2368
Conversation
… during tests so that the output will match the baseline images
|
I'm not sure if there's a way around that. We have to create tests in some locale. If this means that the small fraction of users (mainly developers) who run the tests have to install the I tried using the "C" locale, but I don't know if that guarantees English month names. |
A lot of tests fail on Windows because |
@cgohlke, That doesn't work on linux or OS X, so I imagine the idea would be to use a try/except to use it if en_US.UTF-8 fails. |
Sure, neither |
@cgohlke Looks like we'll need to some conditional logic on the output of It looks like, for Windows, |
On 2013/09/08 11:38 AM, Damon McDougall wrote:
Why not just try the one that is there now, and if that fails, use the |
|
Oh, I'm fine with that solution too, I was just being cautious about locales working on different platforms. I had no idea whether
Ok, I'll patch that up and open a pull request. Thanks for taking the time to investigate. |
@cgohlke, @dmcdougall : What do you guys think of #2396 as a solution? |
This fixes the part of #2343 related to the date strings not matching the baseline images. Since the baseline images were created (by me) in the en_US.UTF-8 locale, we should run the tests in that locale, too, so the output files will match the baseline images.