Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections to cbook.warn_deprecated calls(). #2371

Merged
merged 2 commits into from Sep 4, 2013

Conversation

ianthomas23
Copy link
Member

Some cbook.warn_deprecated() calls are missing explicit use of the kwarg name. Without it, the arguments are interpreted as the previous kwarg message, which causes the default deprecation message to be overridden with the somewhat less useful function name.

I am treating this as a bug and so the PR is based on v1.3.x rather than master.

@ianthomas23
Copy link
Member Author

Rebased and changed cbook.warn_deprecated as it was ignoring the obj_type argument, again making the deprecation message incorrect.

@mdboom
Copy link
Member

mdboom commented Sep 4, 2013

👍 Travis failure is a false negative.

mdboom added a commit that referenced this pull request Sep 4, 2013
Corrections to cbook.warn_deprecated calls().
@mdboom mdboom merged commit 8bad5f7 into matplotlib:v1.3.x Sep 4, 2013
@ianthomas23 ianthomas23 deleted the warn_deprecated_correction branch July 8, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants