Corrections to cbook.warn_deprecated calls(). #2371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
cbook.warn_deprecated()
calls are missing explicit use of the kwargname
. Without it, the arguments are interpreted as the previous kwargmessage
, which causes the default deprecation message to be overridden with the somewhat less useful function name.I am treating this as a bug and so the PR is based on v1.3.x rather than master.