Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fixed github stats retrieval #2406

Merged
merged 1 commit into from Oct 1, 2013

Conversation

cpelley
Copy link

@cpelley cpelley commented Sep 10, 2013

Currently urllib is used to retrieve a json file from Github, however
Github url used is not 'static', urllib2 required to retrieve
information from Github.

Currently urllib is used to retrieve a json file from Github, however
Github url used is not static url, urllib2 required to retrieve
information from Github.
@mrterry
Copy link
Contributor

mrterry commented Sep 11, 2013

For py3k compatibility, shouldn't this use six.moves.urllib instead?

@mdboom
Copy link
Member

mdboom commented Sep 11, 2013

six.moves.urllib was only added in six 1.4 (which came out less than a couple of weeks ago). I don't think we should rely on it being there yet.

@mdboom
Copy link
Member

mdboom commented Sep 11, 2013

But that does raise the larger point, that this file has not been converted to use six at all yet -- I missed it because it's not part of the library or the test suite. I have no idea whether it even works with Python 3.

@pelson
Copy link
Member

pelson commented Oct 1, 2013

Merging this. There is no problem with the change, but there is certainly a larger question being raised here which we should address separately (when one of us is using Python3 on a day-to-day basis, I guess 😉 ).

pelson added a commit that referenced this pull request Oct 1, 2013
@pelson pelson merged commit 926bddc into matplotlib:master Oct 1, 2013
pelson added a commit that referenced this pull request Oct 1, 2013
@mdboom
Copy link
Member

mdboom commented Oct 1, 2013

cherry-picked to v1.3.x as 70067f8

@cpelley cpelley deleted the fixed_stats-retrieve branch October 1, 2013 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants