Catch stderr as well as stdout #2441
Conversation
| @@ -269,7 +269,7 @@ def get_fontconfig_fonts(fontext='ttf'): | |||
|
|
|||
| fontfiles = {} | |||
| try: | |||
| pipe = subprocess.Popen(['fc-list', '', 'file'], stdout=subprocess.PIPE) | |||
| pipe = subprocess.Popen(['fc-list', '', 'file'], stdout=subprocess.PIPE, stderr=subprocess.PIPE) | |||
There was a problem hiding this comment.
please consider wrapping this over multiple lines to conform with the PEP8 80 character limit.
|
For completeness' sake, can you provide the error message produced? I want to confirm it's innocuous before hiding it. |
|
dyld: Library not loaded: /usr/X11/lib/libfreetype.6.dylib This is something unique to our environment, because there is a version of libfreetype loaded from qt that is incompatible with a version in fc-list. This doesn't cause any problems with matplotlib fonts, since we fall back to font search from OSXInstalledFonts() because not every user has X11 installed with OS X anyway. Moreover, we only show the error from fc-list, but no error from where it comes from in matplotlib, so the error message is disconnected and frightening. |
|
@torcolvin: Would you mind rebasing this? It looks like a conflict has crept in in the meantime. Once that's done and Travis passes, I think this is good to merge. |
|
OK, I rebased. |
We ignore if there is a bad return, and otherwise you have functional
code, but spurious and scary error reporting.
This happens for us on OS X, where you can have mismatched freetype loaded by system and from macports.