Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving to in-memory file-like objects in Postscript backend #2512

Merged
merged 3 commits into from Oct 14, 2013

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Oct 11, 2013

This is a follow on to #2498. (I tried to make a PR against @megies branch, but github won't let me for some reason).

This opened up a whole can of worms, exacerbated by the fact that there are 3 of these file-like objects all with subtley different behavior, and we want to support all of them.

@mdboom
Copy link
Member Author

mdboom commented Oct 14, 2013

@megies: Would you mind confirming that this fixes your original bug?

@megies
Copy link
Contributor

megies commented Oct 14, 2013

Thanks @mdboom. Yes, this fixes also the original problem (the test made sure of that already but I checked separately anyway).

mdboom added a commit that referenced this pull request Oct 14, 2013
Fix saving to in-memory file-like objects in Postscript backend
@mdboom mdboom merged commit a3d2992 into matplotlib:master Oct 14, 2013
@mdboom mdboom deleted the ps_StringIO branch August 7, 2014 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants