Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mpl toolkit pep8 #2514

Merged
merged 2 commits into from Oct 28, 2013
Merged

Mpl toolkit pep8 #2514

merged 2 commits into from Oct 28, 2013

Conversation

tacaswell
Copy link
Member

pep8 clean up on files in mpl_toolkit.axes_grid1

mpl_toolkit does not currently get tested for code compliance, only the matplotlib namespace is. Do we want to test mpl_toolkit too?

Made a few non-formatting changes. Removed some mutable default arguments and change foo == None test to foo is None

 - removed mutable default values
 - foo == None -> foo is None
@@ -125,15 +126,14 @@ def _config_axes(self):
# axis.major_ticks.set_visible(True)
# axis.minor_ticks.set_visible(True)


#axis.major_ticklabels.set_size(int(axis.major_ticklabels.get_size()*.9))
#axis.major_ticklabels.set_size(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could remove the dead code ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going for minimal changes to make the pep8 checker happy.

@NelleV
Copy link
Member

NelleV commented Oct 14, 2013

LGTM 👍

pelson added a commit that referenced this pull request Oct 28, 2013
@pelson pelson merged commit ecbbd81 into matplotlib:master Oct 28, 2013
@tacaswell tacaswell deleted the mpl_toolkit_pep8 branch October 28, 2013 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants