more informative exceptions for empty/not-existing images in compare_images() #2567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're reusing the
compare_images()
function in a context manager that triggers acompare_images()
in__exit__()
(to have as little duplicated code as possible). In case of problems during plotting inside the with statement,compare_images()
is triggered on an empty file, raising misleading exceptions like:I've taken care of this on our end, but I thought this might be useful for matplotlib in general, too (or at least won't hurt). Allthough.. when not wrapped in a context manager a different exception will likely be raised earlier when plotting fails, so, feel free to close without merging. ;)