Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fixes thee probllem brought up in the mailing list with the recent spectrum improvements #2571

Merged
merged 1 commit into from Nov 11, 2013

Conversation

toddrjen
Copy link
Contributor

@toddrjen toddrjen commented Nov 2, 2013

Tobias Megies brought up issue #2565 regarding my recent improvements in the spectral functions. I found I had switched the order of window and detrend operations. I have fixed the problem as well as implementing new tests to better check for this sort of problem in the future.

I also added one additional unrelated test.

…s to catch these sorts of problems in the future
@toddrjen
Copy link
Contributor Author

toddrjen commented Nov 5, 2013

Rebase on master

@megies
Copy link
Contributor

megies commented Nov 6, 2013

I can confirm that the proposed change lets our failing test in @obspy pass again (see #2565).

@megies
Copy link
Contributor

megies commented Nov 11, 2013

@mdboom, @pelson, can somebody please merge this or mark it as release critical? This fixes inadvertently changed behavior in psd functions. Things would get real messy if a release would be done without this being merged beforehand.

tacaswell added a commit that referenced this pull request Nov 11, 2013
This fixes thee probllem brought up in the mailing list with the recent spectrum improvements
@tacaswell tacaswell merged commit ff304e4 into matplotlib:master Nov 11, 2013
@megies
Copy link
Contributor

megies commented Nov 11, 2013

Thanks @tacaswell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants