Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AffineBase.__eq__ should not raise an exception when the other does not ... #2581

Merged
merged 1 commit into from Nov 7, 2013

Conversation

leejjoon
Copy link
Contributor

@leejjoon leejjoon commented Nov 7, 2013

...have "is_affine" attribute.

I think the following code

ax.transAxes == "data"

should return False. It currently raises an exception.

@mdboom
Copy link
Member

mdboom commented Nov 7, 2013

👍

mdboom added a commit that referenced this pull request Nov 7, 2013
AffineBase.__eq__ should not raise an exception when the other does not ...
@mdboom mdboom merged commit bd70008 into matplotlib:v1.3.x Nov 7, 2013
@terrycojones
Copy link

We've just run into this issue too. But it seems to be fixed in 1.4.3 (and was an issue in 1.3.1).

So this ticket can be closed, I think.

@jenshnielsen
Copy link
Member

Thanks for confirming. This is a merged Pull request not an issue so it is actually already closed

@terrycojones
Copy link

Ah, wait... the original ticket suggests that __eq__ not raise "an exception". As it stood then, it would raise AttributeError due to no is_affine attribute. But with the fix in 1.4.3 it still raises, but it's a NotImplemented. So maybe the issue shouldn't be closed - depends what the original ticket opener wanted.

@terrycojones
Copy link

@jenshnielsen - OK, I see :-) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants