Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EHN: add a span_stays option to widget.SpanSelector #2595

Merged
merged 2 commits into from Jan 13, 2014
Merged

EHN: add a span_stays option to widget.SpanSelector #2595

merged 2 commits into from Jan 13, 2014

Conversation

Tillsten
Copy link
Contributor

If true, the selected span stays visible.

If true, the selected span stays visible.
@Tillsten
Copy link
Contributor Author

Tillsten commented Dec 5, 2013

If there is no intrest, should i close the PR?

@WeatherGod
Copy link
Member

heh, didn't notice it the first time through.

It is intriguing. Perhaps a "usage story" may make it clearer how it would be used? Also, you have some extraneous whitespace in your diff.

@Tillsten
Copy link
Contributor Author

Tillsten commented Dec 5, 2013

The usage story is quite simple: Right now, the selection vanishs right after selecting it. In a lot
of cases, e.g color histograms, it is helpful to see the selection. In the long run, the selection
should also be moveable (see chacos range 2d) and resizeable.

Note: The second artist is necessary due to blitting (maybe one can work around this, but i didn't).

@pelson
Copy link
Member

pelson commented Jan 9, 2014

👍 once the whitespace issues have been tidied up. @WeatherGod - please do the honours when you're happy.

removed whitespace
tacaswell added a commit that referenced this pull request Jan 13, 2014
EHN: add a span_stays option to widget.SpanSelector
@tacaswell tacaswell merged commit 4d244bb into matplotlib:master Jan 13, 2014
@Tillsten Tillsten deleted the patch-1 branch January 13, 2014 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants