Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchored sizebar fontprop #2712

Merged
merged 4 commits into from Jan 13, 2014
Merged

Conversation

pelson
Copy link
Member

@pelson pelson commented Jan 9, 2014

Closes #2585

Fix: color argument was not setting the color of the textlabel
Add: setting the font-size through the fontsize argument
Removed the old fontsize parameter.
And fix: some typos in the example in the docstring
@pelson
Copy link
Member Author

pelson commented Jan 9, 2014

Waiting for travis, then I'm 👍 on merging this.

@iMichka
Copy link
Contributor

iMichka commented Jan 10, 2014

Just to remind you what I said on the original topic, the argument should perhaps be fontproperties instead of fontprops, to be consistent ?
I hope this PR can be merged for the 1.4 release :)

@magnunor
Copy link
Contributor

I changed "fontprops" to "fontproperties", but I'm not sure how to add the commit to this pull request.

magnunor@63f9730

@tacaswell
Copy link
Member

@magnunor create a PR against pelson's branch.

@magnunor
Copy link
Contributor

I made a PR against pelson's branch: pelson#7

Modify AnchoredSizeBar: change fontprops argument to fontproperties
pelson added a commit that referenced this pull request Jan 13, 2014
@pelson pelson merged commit e3e55fd into matplotlib:master Jan 13, 2014
@pelson pelson deleted the anchored_sizebar_fontprop branch February 12, 2014 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants